Skip to content

fix: should trigger afterRender twice when render to the same target twice #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imsobear merged 6 commits into from
Jul 13, 2020
Merged

fix: should trigger afterRender twice when render to the same target twice #1952

imsobear merged 6 commits into from
Jul 13, 2020

Conversation

@imsobear
Copy link
Collaborator

@imsobear imsobear commented Jul 10, 2020

Close #1950

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@imsobear imsobear mentioned this pull request Jul 10, 2020
Merged
@imsobear imsobear changed the title Fix portal before render fix create-portal not trigger driver afterRender Jul 10, 2020
@imsobear imsobear changed the base branch from release-rax to master July 10, 2020 08:24
@imsobear imsobear changed the base branch from master to release-rax July 10, 2020 08:24
@imsobear imsobear changed the title fix create-portal not trigger driver afterRender fix: create-portal not trigger driver afterRender Jul 10, 2020
@imsobear imsobear requested a review from yuanyan July 10, 2020 09:09
@imsobear
Copy link
Collaborator Author

imsobear commented Jul 10, 2020

补充一个测试用例

@weekly-digest weekly-digest bot mentioned this pull request Jul 12, 2020
Closed
@imsobear imsobear changed the base branch from release-rax to master July 13, 2020 08:30
@imsobear imsobear changed the base branch from master to release-rax July 13, 2020 08:30
@imsobear imsobear changed the title fix: create-portal not trigger driver afterRender fix: should trigger afterRender twice when render to the same target twice Jul 13, 2020
@imsobear imsobear merged commit 9fb5598 into release-rax Jul 13, 2020
@imsobear imsobear deleted the fix-portal-beforeRender branch July 13, 2020 13:56
imsobear added a commit that referenced this pull request Jul 14, 2020
@imsobear
release: [email protected] (#1953)
4f48f1f 
* fix: should trigger afterRender twice when render to the same target twice (#1952)

* fix: createPortal mount not trigger afterRender

* fix: createPortal mount() not trigger afterRender

* chore: add test case
@weekly-digest weekly-digest bot mentioned this pull request Jul 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjun1011 chenjun1011 chenjun1011 approved these changes

+1 more reviewer

@yuanyan yuanyan yuanyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] createPortal 没有正常触发 afterRender

5 participants

@imsobear @CLAassistant @yuanyan @chenjun1011