First Homepage #2452
Merged
First Homepage #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6dbe7ed to
c733696
Compare
cbentejac
requested changes
Jul 11, 2024
meshroom/ui/img/Technicolor-Group_RGB_TechnicolorGames_P-TG_Col-Rev.png
Outdated
Show resolved
Hide resolved
d63885b to
6c2e6ee
Compare
b23da49 to
f6b81f7
Compare
cbentejac
requested changes
Aug 9, 2024
556a1e4 to
02550d0
Compare
We need to check and create the thumbnail if it does not exist.
When the elements are being initialized, their sizes is not yet correctly set. Since the paddings for the `MaterialToolLabelButtons` is computed dynamically depending on other elements' size, we need to add safeguard to ensure that the padding can never be larger than the container's size.
This avoids getting some "Unknown 'c' protocol error".
Defining the height of the `MaterialToolLabelButton` as its content height creates binding loop, and is not useful as the implicit height already is the content's height.
This commit checks whether there is a node in the graph before trying to determine the size and position of the bounding box. If the graph is empty, an bounding box set with 0s is returned.
An `active` property is added to the `Reconstruction` object to share whether it has been initialized or not.
02550d0 to
cb062a4
Compare
cbentejac
approved these changes
Aug 26, 2024
45e5734 to
bed1e29
Compare
f51425d to
3105be4
Compare
3105be4 to
e8eeccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First implementation of Homepage. The aim is to have something at the opening of Meshroom.
Sponsors section with redirection to websites
Grid view for recent projects
Links to start section