SQL Admin Manager refinements and standardisation #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headline
requested changes
Mar 26, 2019
Member
|
Good catch, thanks for this. I think we could go a step further and remove the hard coded 1st dim size.
|
Headline
approved these changes
Mar 26, 2019
MitchDizzle
reviewed
Apr 6, 2019
| #define SCHEMA_UPGRADE_1 1409 | ||
|
|
||
| int current_version[4] = {1, 0, 0, CURRENT_SCHEMA_VERSION}; | ||
| int current_version[] = {1, 0, 0, CURRENT_SCHEMA_VERSION}; |
There was a problem hiding this comment.
Weird design question but why is it '1.0.0.%VERSION%" why not just the version without the prefix of '1.0.0.'?
(I know this probably isn't the right place to ask this either.)
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
sizeof()function to declare the size of the for loops as opposed to hard-coding the value because it feels cleaner to do it that way.