chore(deps): update mariadb docker tag to v10.8.2 #29
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
| services: | ||
| db: | ||
| # We use a mariadb image which supports both amd64 & arm64 architecture | ||
| image: mariadb:10.6.4-focal | ||
| image: mariadb:10.8.2-focal | ||
| # If you really want to use MySQL, uncomment the following line | ||
| #image: mysql:8.0.27 | ||
| command: '--default-authentication-plugin=mysql_native_password' |
There was a problem hiding this comment.
Bug: The MariaDB service in docker-compose.yml is missing the MARIADB_AUTO_UPGRADE=1 environment variable, which is required for upgrading existing database volumes from version 10.6 to 10.8.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The docker-compose.yml file upgrades MariaDB from version 10.6 to 10.8 but omits the MARIADB_AUTO_UPGRADE=1 environment variable. The official MariaDB Docker image requires this variable to automatically run mariadb-upgrade on startup when a version mismatch is detected. Because the service uses a persistent named volume (db_data), existing deployments with data from version 10.6 will fail to start. The MariaDB 10.8 server will encounter incompatible system tables from the older version, leading to a server crash or an unstable state with authentication failures.
💡 Suggested Fix
Add the MARIADB_AUTO_UPGRADE=1 environment variable to the db service definition within the docker-compose.yml file. This will trigger the container's entrypoint script to automatically upgrade the system tables, ensuring compatibility with MariaDB 10.8 for existing deployments.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/features/cms/wordpress/docker-compose.yml#L1-L7
Potential issue: The `docker-compose.yml` file upgrades MariaDB from version 10.6 to
10.8 but omits the `MARIADB_AUTO_UPGRADE=1` environment variable. The official MariaDB
Docker image requires this variable to automatically run `mariadb-upgrade` on startup
when a version mismatch is detected. Because the service uses a persistent named volume
(`db_data`), existing deployments with data from version 10.6 will fail to start. The
MariaDB 10.8 server will encounter incompatible system tables from the older version,
leading to a server crash or an unstable state with authentication failures.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7722918
This PR contains the following updates:
10.6.4-focal->10.8.2-focalConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.