Skip to content

Conversation

@erwinmombay
Copy link
Member

No description provided.

@erwinmombay erwinmombay changed the title [DO NOT SUBMIT] remove windowconfig option remove windowconfig Jul 20, 2016
@cramforce
Copy link
Member

Could you give me some context? Is this being added externally?

@erwinmombay
Copy link
Member Author

@cramforce correct, we will switch it to the gulp prepend-global task

@erwinmombay
Copy link
Member Author

erwinmombay commented Jul 20, 2016

the reason this was added originally during dist was for modifying AMP_CONFIG during test. but that seems to have been solved

@dvoytenko
Copy link
Contributor

LGTM from my side. Deferring to @cramforce for the final approval.

@cramforce
Copy link
Member

LGTM

@erwinmombay erwinmombay merged commit 4618a11 into ampproject:master Jul 20, 2016
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants