Fix travis skip matching #4973
Merged
Fix travis skip matching #4973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Canary cuts are hard checkouts, meaning they have no previous commit to compare against. Because there's no comparison, the diff check would return an empty string. Because the empty string passes the "not anything that's not a doc change" check, it would skip Travis.
75d518e to
f4edb59
Compare
erwinmombay
pushed a commit
that referenced
this pull request
Sep 13, 2016
Canary cuts are hard checkouts, meaning they have no previous commit to compare against. Because there's no comparison, the diff check would return an empty string. Because the empty string passes the "not anything that's not a doc change" check, it would skip Travis.
erwinmombay
pushed a commit
that referenced
this pull request
Sep 14, 2016
Canary cuts are hard checkouts, meaning they have no previous commit to compare against. Because there's no comparison, the diff check would return an empty string. Because the empty string passes the "not anything that's not a doc change" check, it would skip Travis.
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Sep 16, 2016
Canary cuts are hard checkouts, meaning they have no previous commit to compare against. Because there's no comparison, the diff check would return an empty string. Because the empty string passes the "not anything that's not a doc change" check, it would skip Travis.
mityaha
pushed a commit
to brightcove-archive/ooyala_amphtml
that referenced
this pull request
Nov 30, 2016
Canary cuts are hard checkouts, meaning they have no previous commit to compare against. Because there's no comparison, the diff check would return an empty string. Because the empty string passes the "not anything that's not a doc change" check, it would skip Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canary cuts are hard checkouts, meaning they have no previous commit to
compare against. Because there's no comparison, the diff check would
return an empty string. Because the empty string passes the "not
anything that's not a doc change" check, it would skip Travis.