fix(@angular/build): exclude all entrypoints of a library from prebundling #29753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94496f2 to
5d04b0c
Compare
5d04b0c to
359686f
Compare
359686f to
e4c4195
Compare
clydin
approved these changes
Mar 6, 2025
packages/angular/build/src/builders/application/execute-build.ts
Outdated
Show resolved
Hide resolved
…dling The configuration now ensures that when a package is listed for exclusion, all paths within that package including sub-paths like `@foo/bar/baz` are marked as external and not prebundled by the development server. For example, specifying `@foo/bar` in the exclude list will prevent the development server from bundling any files from the `@foo/bar` package, including its sub-paths such as `@foo/bar/baz`. This aligns with esbuild external option behaviour https://esbuild.github.io/api/#external Closes angular#29170
e4c4195 to
5daa0e7
Compare
|
The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration now ensures that when a package is listed for exclusion, all paths within that package including sub-paths like
@foo/bar/bazare marked as external and not prebundled by the development server.For example, specifying
@foo/barin the exclude list will prevent the development server from bundling any files from the@foo/barpackage, including its sub-paths such as@foo/bar/baz.This aligns with esbuild external option behaviour https://esbuild.github.io/api/#external
Closes #29170