Skip to content

Find "changed" not only in first "when" condition #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssbarnea merged 3 commits into from
Apr 26, 2023
Merged

Find "changed" not only in first "when" condition #3358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
546f316
Find changed not only in first when condition
klaus-tux Apr 26, 2023
c4cdd35
Merge branch 'main' into find-changed-in-last-when
klaus-tux Apr 26, 2023
07e81f2
Merge branch 'main' into find-changed-in-last-when
ssbarnea Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/playbooks/no_handler_fail.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,10 @@
when:
- result['changed'] == true
- another_condition

- name: This should be a handler 6
ansible.builtin.debug:
msg: why isn't this a handler
when:
- first_condition
- result.changed
5 changes: 3 additions & 2 deletions src/ansiblelint/rules/no_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ def matchtask(

if isinstance(when, list):
for item in when:
return _changed_in_when(item)
if _changed_in_when(item):
return True
if isinstance(when, str):
return _changed_in_when(when)
return False
Expand All @@ -90,7 +91,7 @@ def matchtask(
@pytest.mark.parametrize(
("test_file", "failures"),
(
pytest.param("examples/playbooks/no_handler_fail.yml", 6, id="fail"),
pytest.param("examples/playbooks/no_handler_fail.yml", 7, id="fail"),
pytest.param("examples/playbooks/no_handler_pass.yml", 0, id="pass"),
),
)
Expand Down