feat(doc-style): reporter is defined based on the event#1158
Open
feat(doc-style): reporter is defined based on the event#1158
Conversation
Contributor
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Thanks for the contribution @vgelbgras
I think our main use case for this action was for PR events but it's fine to extend it for push events. Could you investigate the direct use of 'github-check' as a default value (no conditional) ?
| with: | ||
| files: ${{ inputs.files }} | ||
| reporter: github-pr-check | ||
| reporter: ${{ github.event_name == 'pull_request' && 'github-pr-check' || 'github-check' }} |
Contributor
There was a problem hiding this comment.
From the description here I would even consider changing to 'github-check' directly.
Could you give it a try and see how it works on your side ?
Member
There was a problem hiding this comment.
Yeah agreed - seems like github-check would work in all scenarios, right?
Contributor
Author
There was a problem hiding this comment.
Could we have it as input with a default value (github-check) so it is more flexible?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
doc-style/action.ymlfile, updating the logic for thereporterparameter to dynamically select the reporter type based on the event name. This improves compatibility with both pull request and push events.