[#8055] improvement(core): Replace equals() with == for enum comparison in CompatibilityUtils #8080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mparison in CompatibilityUtils (apache#8055)
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Sep 15, 2025
…mparison in CompatibilityUtils (apache#8080) ### What changes were proposed in this pull request? Replace `equals()` method with `==` operator for enum comparison in the `toAuditLogStatus()` method within `CompatibilityUtils` class. Additionally, add a null safety test case to ensure proper handling of null `OperationStatus` parameters. ### Why are the changes needed? 1. Using `==` for enum comparison is more efficient than `equals()` since enums are singletons in Java 2. Added test coverage for null parameter handling to ensure robustness Fix: apache#8055 ### Does this PR introduce _any_ user-facing change? No, this is purely an internal refactoring change. ### How was this patch tested? 1. Existing unit tests continue to pass, ensuring no functional regression 2. Added a new test case `testOperationStatusNullHandling()` to verify proper null parameter handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace
equals()method with==operator for enum comparison in thetoAuditLogStatus()method withinCompatibilityUtilsclass. Additionally, add a null safety test case to ensure proper handling of nullOperationStatusparameters.Why are the changes needed?
==for enum comparison is more efficient thanequals()since enums are singletons in JavaFix: #8055
Does this PR introduce any user-facing change?
No, this is purely an internal refactoring change.
How was this patch tested?
testOperationStatusNullHandling()to verify proper null parameter handling