[#8159] improvement(cli): Use toType() instead of toBasicType() for support more complex types #8227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for type conversion
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Sep 15, 2025
… for support more complex types (apache#8227) ### What changes were proposed in this pull request? This PR updates the `ParseType` class to support parsing of nested complex types (e.g. `list(list(integer))`, `map(string,list(integer))`). ### Why are the changes needed? Currently, the CLI only supports simple types or single-level lists/maps. It fails for more complex definitions like `list(list(integer))` or `map(string,list(integer))`. Fix: apache#8159 ### Does this PR introduce _any_ user-facing change? Users can now define more complex schemas in the CLI, such as: - `list(list(integer))` - `map(string,list(integer))` ### How was this patch tested? - Added new unit tests: - `testParseTypeNestedList` - `testParseTypeMapWithNestedValue` - Executed existing unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the
ParseTypeclass to support parsing of nested complex types (e.g.list(list(integer)),map(string,list(integer))).Why are the changes needed?
Currently, the CLI only supports simple types or single-level lists/maps.
It fails for more complex definitions like
list(list(integer))ormap(string,list(integer)).Fix: #8159
Does this PR introduce any user-facing change?
Users can now define more complex schemas in the CLI, such as:
list(list(integer))map(string,list(integer))How was this patch tested?
testParseTypeNestedListtestParseTypeMapWithNestedValue