Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Bug Fix and performance optimized for rtc #10018

Merged
piiswrong merged 2 commits into from
Mar 9, 2018
Merged

Bug Fix and performance optimized for rtc #10018

piiswrong merged 2 commits into from
Mar 9, 2018

Conversation

@chinakook
Copy link
Contributor

@chinakook chinakook commented Mar 7, 2018

Description

  1. "super().init()" bug is fixed in python 2.
  2. Kernel is initialized in the stage of operator init.

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@chinakook
Bug Fix and performance optimized for rtc
524509e 
1. "super().__init__()" bug is fixed in python 2.
2. Kernel is initialized in the stage of operator init.
@chinakook chinakook requested a review from szha as a code owner March 7, 2018 03:29
@CodingCat
Copy link
Contributor

CodingCat commented Mar 7, 2018

Hi, the community has passed to vote about associating the code changes with JIRA (https://lists.apache.org/thread.html/ab22cf0e35f1bce2c3bf3bec2bc5b85a9583a3fe7fd56ba1bbade55f@%3Cdev.mxnet.apache.org%3E)

We have updated the guidelines for contributors in https://cwiki.apache.org/confluence/display/MXNET/Development+Process, please ensure that you have created a JIRA at https://issues.apache.org/jira/projects/MXNET/issues/ and include the JIRA title in your PR as [MXNET-xxxx] your title where MXNET-xxxx is the jira id

@piiswrong
Copy link
Contributor

piiswrong commented Mar 7, 2018

@CodingCat When was this? JIRA is ancient and arcane. This only adds unnecessary overhead.

piiswrong
piiswrong reviewed Mar 7, 2018
View reviewed changes
example/numpy-ops/custom_softmax_rtc.py Outdated
fwd_kernel_mod = mx.rtc.CudaModule(fwd_src, exports=["fwd<float>", "fwd<double>"])
bwd_kernel_mod = mx.rtc.CudaModule(bwd_src, exports=["bwd<float>", "bwd<double>"])

fwd_kernel_float_signature = "const {0}*, const {0}*, const int, const int".format("float")
Copy link
Contributor

@piiswrong piiswrong Mar 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use format here? seems unnecessary

@chinakook
Update custom_softmax_rtc.py
00a3643 
fix unnessesary format
marcoabreu
marcoabreu suggested changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@marcoabreu marcoabreu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind

marcoabreu
marcoabreu approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@marcoabreu marcoabreu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind

@piiswrong piiswrong merged commit a7ba921 into apache:master Mar 9, 2018
szha pushed a commit that referenced this pull request Mar 15, 2018
@astonzhang @szha
Add vocabulary and embedding (#10074)
092df8f 
* [MXNET-67] Sync master with v1.1.0 branch (#10031)

* [REVIEW REQUIRED] Revert PR #9484 & add additional dependency licenses to LICENSE file (#9701)

* Revert "[Review Required] Fixing Licenses: Cleaning up the Top Level LICENSE file (#9484)"

This reverts commit 8930d96.

* Some more LICENSE fixes

* Adding some more packages to the LICENSE file

* Adding dependencies of dependencies

* update v1.1.0 change log to NEWS.md

* sync README.md from v1.1.0 branch

* revert to correct jenkins url in README

* Parallelization for ROIpooling OP (#9958)

* parallelization for roipooling

* remove some useless computation

* remove useless muls

* add author and retriggering

* retrigger again

* comments to copy and copyto are corrected (#10040)

* Bug Fix and performance optimized for rtc (#10018)

* Bug Fix and performance optimized for rtc

1. "super().__init__()" bug is fixed in python 2.
2. Kernel is initialized in the stage of operator init.

* Update custom_softmax_rtc.py

fix unnessesary format

* set embedding

* Code and test revised

* api implementation done

* license and news

* readme and cpp

* pylint disable

* Add API doc

* less pylint disable

* remove contrib

* move to gluon, revise api doc

* fix import order

* re-test

* relative imports

* re-run test

* revise implementation, test case, and api doc

* re-test
szha pushed a commit to szha/mxnet that referenced this pull request Mar 15, 2018
@astonzhang
Add vocabulary and embedding (apache#10074)
9e4f9d1 
* [MXNET-67] Sync master with v1.1.0 branch (apache#10031)

* [REVIEW REQUIRED] Revert PR apache#9484 & add additional dependency licenses to LICENSE file (apache#9701)

* Revert "[Review Required] Fixing Licenses: Cleaning up the Top Level LICENSE file (apache#9484)"

This reverts commit 8930d96.

* Some more LICENSE fixes

* Adding some more packages to the LICENSE file

* Adding dependencies of dependencies

* update v1.1.0 change log to NEWS.md

* sync README.md from v1.1.0 branch

* revert to correct jenkins url in README

* Parallelization for ROIpooling OP (apache#9958)

* parallelization for roipooling

* remove some useless computation

* remove useless muls

* add author and retriggering

* retrigger again

* comments to copy and copyto are corrected (apache#10040)

* Bug Fix and performance optimized for rtc (apache#10018)

* Bug Fix and performance optimized for rtc

1. "super().__init__()" bug is fixed in python 2.
2. Kernel is initialized in the stage of operator init.

* Update custom_softmax_rtc.py

fix unnessesary format

* set embedding

* Code and test revised

* api implementation done

* license and news

* readme and cpp

* pylint disable

* Add API doc

* less pylint disable

* remove contrib

* move to gluon, revise api doc

* fix import order

* re-test

* relative imports

* re-run test

* revise implementation, test case, and api doc

* re-test
@chinakook chinakook deleted the patch-2 branch March 17, 2018 14:22
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
@chinakook
Bug Fix and performance optimized for rtc (apache#10018)
cd8deff 
* Bug Fix and performance optimized for rtc

1. "super().__init__()" bug is fixed in python 2.
2. Kernel is initialized in the stage of operator init.

* Update custom_softmax_rtc.py

fix unnessesary format
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@chinakook @piiswrong
Bug Fix and performance optimized for rtc (apache#10018)
1a5f39f 
* Bug Fix and performance optimized for rtc

1. "super().__init__()" bug is fixed in python 2.
2. Kernel is initialized in the stage of operator init.

* Update custom_softmax_rtc.py

fix unnessesary format
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@chinakook @zheng-da
Bug Fix and performance optimized for rtc (apache#10018)
6a97a32 
* Bug Fix and performance optimized for rtc

1. "super().__init__()" bug is fixed in python 2.
2. Kernel is initialized in the stage of operator init.

* Update custom_softmax_rtc.py

fix unnessesary format
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@piiswrong piiswrong piiswrong left review comments

@marcoabreu marcoabreu marcoabreu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chinakook @CodingCat @piiswrong @marcoabreu