Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@dabraude
Copy link
Contributor

@dabraude dabraude commented Mar 22, 2018

Description

Added load from function buffers for CPP package

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added equivalent functions for the loading, from buffers instead of files

Comments

  • Duplicates functionality from Python wrapper

@dabraude
Copy link
Contributor Author

@cjolivier01 do you know who should be reviewing this change?

@cjolivier01
Copy link
Member

anyone who choses to :)

0);
if (array_list != nullptr) {
for (mx_uint i = 0; i < out_size; ++i) {
array_list->push_back(NDArray(out_arr[i]));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please call array_list->reserve(out_size)

&out_names),
0);
for (mx_uint i = 0; i < out_size; ++i) {
array_list.push_back(NDArray(out_arr[i]));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call reserve, please

@cjolivier01
Copy link
Member

other than those two minor things, looks good

@dabraude
Copy link
Contributor Author

Done the reserves, perhaps that should be put into the load from file functions too?

@dabraude dabraude closed this Mar 27, 2018
@dabraude dabraude force-pushed the cpp_ndarray_loadfrombuffer branch from fb60e67 to bd9b9c8 Compare March 27, 2018 07:44
@dabraude
Copy link
Contributor Author

balls need to redo this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants