This repository was archived by the owner on Nov 17, 2023. It is now read-only.
New example of custom operator using RTC #9870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
example/numpy-ops/ndarray_softmax.pycontains a custom softmax implementation using RTC. However, it extendsNDArrayOpwhich is deprecated. Moreover the example seems not compatible with the current RTC API. I think that the example confuses newbies like me who didn't know the previous history of the API changes. So I think it is a good idea to remove the broken example and add a new RTC example based onCustomOp. The new exampleexample/numpy-ops/custom_softmax_rtc.pyis based on the existing example (example/numpy-ops/custom_softmax.py) but uses custom CUDA kernels through RTC.Checklist
Essentials
make lint)Changes
example/numpy-ops/ndarray_softmax.pyis removed.example/numpy-ops/custom_softmax_rtc.pyis added.example/numpy-ops/README.mdis updated.