Skip to content

Conversation

@halantown
Copy link

What is the purpose of the change

#apache/rocketmq-connect#181

Brief changelog

Added rocketmq-connect page.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@odbozhou odbozhou added the enhancement New feature or request label Jul 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #101 (bd159cd) into master (63d9da7) will decrease coverage by 5.77%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     76.92%   71.15%   -5.78%     
  Complexity      822      822              
============================================
  Files            91       97       +6     
  Lines          2847     3078     +231     
  Branches        282      292      +10     
============================================
  Hits           2190     2190              
- Misses          500      731     +231     
  Partials        157      157              
Impacted Files Coverage Δ
.../dashboard/config/AuthWebMVCConfigurerAdapter.java 50.00% <0.00%> (-7.15%) ⬇️
...cketmq/dashboard/controller/ConnectController.java 0.00% <0.00%> (ø)
...ketmq/dashboard/model/connect/WorkerConnector.java 0.00% <0.00%> (ø)
...e/rocketmq/dashboard/model/connect/WorkerInfo.java 0.00% <0.00%> (ø)
...e/rocketmq/dashboard/model/connect/WorkerTask.java 0.00% <0.00%> (ø)
...tmq/dashboard/service/impl/ConnectServiceImpl.java 0.00% <0.00%> (ø)
...pache/rocketmq/dashboard/util/HttpRequestUtil.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants