Skip to content

Conversation

@Kontinuation
Copy link
Member

@Kontinuation Kontinuation commented Jun 8, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Fix the code to compute the width and height of the rasterization result. Please refer to the JIRA ticket for a detailed explanation of this problem.

This patch fixes RS_AsRaster, RS_ZonalStats and RS_ZonalStatsAll.

How was this patch tested?

Add new tests for RS_AsRaster, updated assertions for existing RS_AsRaster and zonal stats tests since the bound and width/height will be slightly different from before.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@Kontinuation Kontinuation force-pushed the fix-rasterization branch 2 times, most recently from e52ff26 to 4ceab4d Compare June 8, 2024 02:48
@Kontinuation Kontinuation marked this pull request as ready for review June 8, 2024 05:34
@Kontinuation Kontinuation requested a review from jiayuasu as a code owner June 8, 2024 05:34
@jiayuasu jiayuasu added the bug label Jun 10, 2024
@jiayuasu jiayuasu added this to the sedona-1.6.1 milestone Jun 10, 2024
@jiayuasu jiayuasu merged commit e8ba447 into apache:master Jun 10, 2024
Kontinuation added a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants