Skip to content

Conversation

@furqaankhan
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • I implemented the ST_CoordDim function in Sedona.

How was this patch tested?

  • In my local Ubuntu VM environment.

Did this PR include necessary documentation updates?

  • Yes, I have added the necessary information to the readmes.

@jiayuasu
Copy link
Member

jiayuasu commented Jul 5, 2023

@furqaankhan Please fix the git conflicts.

@jiayuasu
Copy link
Member

jiayuasu commented Jul 7, 2023

@furqaankhan Please fix the failed CI

@DataTypeHint("Double")
public Double eval(@DataTypeHint("Double") Double angleInRadian) {
return org.apache.sedona.common.Functions.degrees(angleInRadian);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not make changes to irrelevant parts of the codebase

Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiayuasu
Copy link
Member

@furqaankhan Please fix the failed CI

@jiayuasu jiayuasu merged commit c764200 into apache:master Jul 12, 2023
@furqaankhan furqaankhan deleted the changes branch July 15, 2023 15:36
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants