Add convenience impls for common types#137
Merged
Conversation
Pratyush
commented
Jan 18, 2024
Pratyush
commented
Jan 18, 2024
4d0bf30 to
e7a75be
Compare
mmagician
approved these changes
Jan 26, 2024
Member
mmagician
left a comment
There was a problem hiding this comment.
One question on the logic, otherwise LGTM
| let elem = elem.to_bytes_le()?; | ||
| bytes.extend_from_slice(&elem); | ||
| // Make sure that there's enough capacity to avoid reallocations. | ||
| bytes.reserve(elem.len() * (self.len() - 1)); |
Member
There was a problem hiding this comment.
Do we do this at each iteration of the loop in case the elements have different len?
Member
Author
There was a problem hiding this comment.
This actually wasn't the smartest logic, but it kind of works out: if the elem.len() is less than or equal to that for previous elems, then don't change the capacity, resulting in a no-op. If elem.len() is larger than that for previous elems, it will reserve more space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer