[fastapi] Fix false positives for path parameters that FastAPI doesn't recognize (FAST003)
#20687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
|
Contributor
|
It makes sense to me just to use the same regex. It looks like they just iterate over the regex matches to extract parameters too, which might help us simplify |
ntBre
approved these changes
Oct 9, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I pushed one commit pushing the refactor a bit further. Now that we're using a regex, we can just use Regex::captures_iter. I also added a link to the upstream regex for easier reference in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20680