refactor: toolchainize py_proto_library #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not ready yet; waiting for bazelbuild/rules_proto#194 to gate this feature. |
Contributor
Author
|
fixes #1080 consequently. |
04eaf58 to
7128428
Compare
ar3s3ru
reviewed
Dec 7, 2023
Relies on bazelbuild/rules_proto#207 landing and being available in a rules_proto release.
It has a bug with bzlmod where it tries to reference the label of the users toolchain_type, leading to an error like com.google.devtools.build.lib.packages.BuildFileNotFoundException: no such package '@@[unknown repo 'rules_python' requested from @@rules_proto~]//python/proto': The repository '@@[unknown repo 'rules_python' requested from @@rules_proto~]' could not be resolved: No repository visible as '@rules_python' from repository '@@rules_proto~'
abfdd9c to
89f0a56
Compare
Contributor
Author
|
Okay this is green now. had to rename the workspace because bazelbuild/bazel#18683 (comment) |
This was referenced Jun 7, 2024
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Jun 11, 2024
…7078) This was originally landed in bazel-contrib/rules_python#1577 However the fork of py_proto_library brought to the protobuf repo was from an earlier commit: 8257c44 (cl/623401031 for googlers) Thus the fix was lost. This PR simply cherry-picks that change. Closes #17078 COPYBARA_INTEGRATE_REVIEW=#17078 from alexeagle:py_proto_toolchain 226540e PiperOrigin-RevId: 642123868
TinyTinni
pushed a commit
to TinyTinni/protobuf
that referenced
this pull request
Jun 15, 2024
…otocolbuffers#17078) This was originally landed in bazel-contrib/rules_python#1577 However the fork of py_proto_library brought to the protobuf repo was from an earlier commit: protocolbuffers@8257c44 (cl/623401031 for googlers) Thus the fix was lost. This PR simply cherry-picks that change. Closes protocolbuffers#17078 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#17078 from alexeagle:py_proto_toolchain 226540e PiperOrigin-RevId: 642123868
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
…otocolbuffers#17078) This was originally landed in bazel-contrib/rules_python#1577 However the fork of py_proto_library brought to the protobuf repo was from an earlier commit: protocolbuffers@8257c44 (cl/623401031 for googlers) Thus the fix was lost. This PR simply cherry-picks that change. Closes protocolbuffers#17078 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#17078 from alexeagle:py_proto_toolchain 226540e PiperOrigin-RevId: 642123868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables use of
--incompatible_enable_proto_toolchain_resolutionflag that launched in Bazel 7. This allows users to choose a pre-builtprotocor use the runtime from https://pypi.org/project/protobuf/ rather than be forced to use hard-coded values in Bazel core.This change is also happening in other language rulesets that provide first-class protobuf support, e.g.
bazel-contrib/rules_go#3895
No update to CHANGELOG.md in this PR as the feature is not yet documented for end-users, this just makes it possible to enable the flag. A follow-up PR will provide user instructions.