Skip to content
This repository was archived by the owner on Jan 14, 2026. It is now read-only.

Conversation

@comius
Copy link
Collaborator

@comius comius commented Sep 20, 2022

This supports using rules_proto as a bzlmod dependency.

@comius comius requested a review from meteorcloudy September 20, 2022 10:51
@comius comius requested a review from lberki as a code owner September 20, 2022 10:52
lberki
lberki previously approved these changes Sep 20, 2022
@comius
Copy link
Collaborator Author

comius commented Sep 20, 2022

@meteorcloudy interesting, I don't get the error running locally. Is there another workaround for local_cc_config?

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/bazel_tools/tools/cpp/BUILD:58:19: every rule of type cc_toolchain_alias implicitly depends upon the target '@[unknown repo 'rules_cc.0.0.1.cc_configure.local_config_cc' requested from @]//:toolchain', but this target could not be found because of: no such package '@[unknown repo 'rules_cc.0.0.1.cc_configure.local_config_cc' requested from @]//': The repository '@[unknown repo 'rules_cc.0.0.1.cc_configure.local_config_cc' requested from @]' could not be resolved: Repository '@rules_cc.0.0.1.cc_configure.local_config_cc' is not visible from repository '@'

@comius comius requested a review from meteorcloudy September 20, 2022 15:21
@comius comius changed the title Bzlmod rules proto Add MODULE.bazel to rules proto Sep 21, 2022
@comius comius self-assigned this Sep 21, 2022
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!!

@comius comius added the ready to pull Required label for automatic import to Google label Sep 21, 2022
@kotlaja kotlaja merged commit 29f9c37 into bazelbuild:master Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready to pull Required label for automatic import to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants