-
Notifications
You must be signed in to change notification settings - Fork 73
refactor: remove protobuf_workspace #181
Conversation
comius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change!
Please also fix the CI problems.
|
quick heads up that I renamed the branch master to main, so you may need to kick this a bit if something goes funny there |
comius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix CI failures.
In case you can't access them, let me know. The failures are: |
done |
|
Beware that there are tests that depend on protobuf repo. should I remove those as well? |
Could you add a dev dependency to protobuf repo and update the test so that it uses sources? |
19dbb3f can I take this change back then? |
Yes, please do. Sorry for the trouble |
|
@comius PTAL. |
comius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a buildifier warning, please run buildifier MODULE.bazel WORKSPACE dev_deps.bzl
Friendly ping. Please also remove the toplevel BUILD file. I'll create that one in a separate PR, that follow licensing guidelines. (ATM that file breaks copybara) |
d80cf48 to
06cf82d
Compare
currently, there are no prebuilt binaries available, it's built from the source using the protobuf workspace. Will add the toolchain for prebuilt binaries in a follow-up
RELNOTES[INC]: protobuf_repo was removed