This repository was archived by the owner on Jan 14, 2026. It is now read-only.
chore: automate releases #189
Merged
+113
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
reviewed
Oct 31, 2023
This also fixes our current dependency on GitHub archives which are not guaranteed to be stable, https://github.com/bazelbuild/bazel-central-registry/pull/332/files#diff-7288b02983f19cbe12177d5f193a6bfc533e352fc44fbe12cdb93e1c8c28dcd1R4 which requires a special 'skip-url-stability-check' label on the BCR PR Instead, we run 'git archive' to create the release artifact. We can now prune the tests/ folder from that artifact, which lets us remove an exclusion from the presubmit as well.
comius
reviewed
Oct 31, 2023
alexeagle
added a commit
to aspect-build/rules_esbuild
that referenced
this pull request
Nov 1, 2023
alexeagle
added a commit
to aspect-build/rules_py
that referenced
this pull request
Nov 1, 2023
alexeagle
added a commit
to aspect-build/rules_ts
that referenced
this pull request
Nov 1, 2023
alexeagle
added a commit
to aspect-build/rules_ts
that referenced
this pull request
Nov 1, 2023
alexeagle
added a commit
to bazel-contrib/rules-template
that referenced
this pull request
Nov 1, 2023
Illustrate how to stamp the version into the release artifact as well, which we've needed in only a couple of rulesets. Makes it match bazelbuild/rules_proto#189
alexeagle
added a commit
to bazel-contrib/rules-template
that referenced
this pull request
Nov 1, 2023
Illustrate how to stamp the version into the release artifact as well, which we've needed in only a couple of rulesets. Makes it match bazelbuild/rules_proto#189
alexeagle
added a commit
to bazel-contrib/bazel-lib
that referenced
this pull request
Nov 1, 2023
alexeagle
added a commit
to aspect-build/rules_py
that referenced
this pull request
Nov 1, 2023
Makes it match bazelbuild/rules_proto#189 --- ### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Manual testing; please provide instructions so we can reproduce: I made a clean git repo and verified the export-* settings work in .gitattributes
alexeagle
added a commit
to bazel-contrib/bazel-lib
that referenced
this pull request
Nov 1, 2023
alexeagle
added a commit
to aspect-build/rules_esbuild
that referenced
this pull request
Nov 1, 2023
alexeagle
added a commit
to aspect-build/rules_ts
that referenced
this pull request
Nov 1, 2023
comius
reviewed
Nov 2, 2023
comius
previously approved these changes
Nov 2, 2023
comius
approved these changes
Nov 2, 2023
bellspice
approved these changes
Nov 2, 2023
alexeagle
added a commit
to bazel-contrib/bazel-lib
that referenced
this pull request
Dec 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes our current dependency on GitHub archives which are not guaranteed to be stable, https://github.com/bazelbuild/bazel-central-registry/pull/332/files#diff-7288b02983f19cbe12177d5f193a6bfc533e352fc44fbe12cdb93e1c8c28dcd1R4 which requires a special 'skip-url-stability-check' label on the BCR PR
Instead, we run 'git archive' to create the release artifact. We can now prune the tests/ folder from that artifact, which lets us remove an exclusion from the presubmit as well.
Fixes #188