Skip to content

Conversation

@mh21
Copy link
Contributor

@mh21 mh21 commented Feb 5, 2024

Candidate sites were found via

find . -iname '*.py' -exec pylint --disable all --enable W1401 {} +

and

git grep  '\<re\..*(["'"'].*\\\\"  | grep '\.py:'

Fixes #211

@mh21
Copy link
Contributor Author

mh21 commented Feb 5, 2024

@StykMartin please review carefully, I don't really trust myself here 🙈

@StykMartin
Copy link
Contributor

StykMartin commented Feb 6, 2024

flames

@mh21 can you please remove changes to LC and Server?
These components are not yet ported to Python 3 (I have Python 3 LC in my fork atm), and I would like to handle them separately, as this will require some additional testing there anyway.

  • I want to avoid backporting LC/Server stuff.

@mh21 mh21 force-pushed the escapes-py-312 branch 2 times, most recently from 06c1f32 to 69b816b Compare February 6, 2024 07:48
@mh21 mh21 changed the title Fix invalid escape sequences on Python 3.12 Fix invalid escape sequences on Python 3.12 in client code Feb 6, 2024
@mh21
Copy link
Contributor Author

mh21 commented Feb 7, 2024

@StykMartin updated the PR 🤗

@StykMartin
Copy link
Contributor

Thank you @mh21. I'll check it out right after my workday is over.

@StykMartin StykMartin changed the base branch from python-3 to release-29 February 7, 2024 12:48
@StykMartin StykMartin changed the base branch from release-29 to python-3 February 7, 2024 12:49
@StykMartin StykMartin self-requested a review February 7, 2024 21:16
@StykMartin
Copy link
Contributor

/packit build

Candidate sites were found via

    find . -iname '*.py' -exec pylint --disable all --enable W1401 {} +

and

    git grep  '\<re\..*(["'"'].*\\\\"  | grep '\.py:'

Signed-off-by: Michael Hofmann <[email protected]>
@StykMartin
Copy link
Contributor

Looks good, thanks @mh21!
I thought about it and I will push this as a separate 29.1.
The reason is that I want to release this on PyPI as well (where I can't just backport).

I can guarantee that this release will be done this weekend. I will post Bodhi updates here so you can +1/-1 karma.

@StykMartin StykMartin merged commit 830eda3 into beaker-project:python-3 Feb 9, 2024
@mh21 mh21 deleted the escapes-py-312 branch March 1, 2024 13:46
@mh21
Copy link
Contributor Author

mh21 commented Mar 1, 2024

@StykMartin sorry it took me so long to come back to this, thank you very much! 🤗

The user that reported this has verified that this fixed his issue 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]SyntaxWarning: invalid escape sequence on python3.12

2 participants