Skip to content

fix: base64.encodestring() doesn't exist in Python 3.9 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renanrodrigo merged 1 commit into from
Nov 13, 2020
Merged

fix: base64.encodestring() doesn't exist in Python 3.9 #75

renanrodrigo merged 1 commit into from
Nov 13, 2020

Conversation

@xhernandez
Copy link
Contributor

@xhernandez xhernandez commented Nov 12, 2020

Python 3.9 has removed the deprecated method 'encodestring' from base64 module.
It needs to be replaced by ' encodebytes'.

Signed-off-by: Xavi Hernandez [email protected]

@xhernandez xhernandez mentioned this pull request Nov 12, 2020
Closed
@StykMartin StykMartin self-requested a review November 12, 2020 11:42
@StykMartin StykMartin changed the base branch from develop to release-28 November 12, 2020 11:42
@StykMartin
Copy link
Contributor

StykMartin commented Nov 12, 2020

/test
/packit build

@xhernandez
Copy link
Contributor Author

xhernandez commented Nov 12, 2020

@StykMartin I've just checked that there are other places where encodestring is used. I'll send another commit to also update those.

@StykMartin
Copy link
Contributor

StykMartin commented Nov 12, 2020 •
edited
Loading

@StykMartin I've just checked that there are other places where encodestring is used. I'll send another commit to also update those.

Actually no. I believe that other places are Python 2 only and it should stay that way.
Only common and client are Python 3 supported.

@xhernandez
Copy link
Contributor Author

xhernandez commented Nov 12, 2020

Actually no. I believe that other places are Python 2 only and it should stay that way.
Only common and client are Python 3 supported.

Ok

@StykMartin
Copy link
Contributor

StykMartin commented Nov 12, 2020

Server/bkr/server/BasicAuthTransport.py - Python 2 only
LabController/aux/anamon - Python 2 only
IntegrationTests/src/bkr/inttest/server/selenium/test_login.py - Python 2 only
Common/bkr/common/xmlrpc2.py - Python 2 only

StykMartin
StykMartin approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@StykMartin StykMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Pylint failed due to Python 2 only.
We all good.

@StykMartin
Copy link
Contributor

StykMartin commented Nov 12, 2020

Ready for merge @renanrodrigo

@renanrodrigo renanrodrigo merged commit 26769b9 into beaker-project:release-28 Nov 13, 2020
@StykMartin StykMartin mentioned this pull request Nov 14, 2020
Merged
@xhernandez xhernandez deleted the issue-74 branch November 16, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StykMartin StykMartin StykMartin approved these changes

@renanrodrigo renanrodrigo renanrodrigo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xhernandez @StykMartin @renanrodrigo