Fix: Get console logs raises Exception #86
Conversation
|
/test |
renanrodrigo
left a comment
There was a problem hiding this comment.
NIT2 - the commit message could be more descriptive than 'replace hotfix', making explicit what the change is about
StykMartin
left a comment
There was a problem hiding this comment.
- Stickler CI is complaining.
- I don't understand what the commit message is trying to say. Would be nice to reword it.
IntegrationTests/src/bkr/inttest/labcontroller/test_watchdog.py
Outdated
Show resolved
Hide resolved
| 'system': None}, self.watchdog) | ||
| self.assert_(not self.monitor_guest.console_watch.logfiles) | ||
|
|
||
| with patch.object(Watchdog, 'spawn_monitor', side_effect=TypeError('Boom!')): |
There was a problem hiding this comment.
You patching it here, I would expect to see some verification afterward.
There was a problem hiding this comment.
The verification was that it didn't crash and the log entry I wrote didn't crash. Code has since been removed.
IntegrationTests/src/bkr/inttest/labcontroller/test_watchdog.py
Outdated
Show resolved
Hide resolved
dd09385 to
c4f3fb7
Compare
cbouchar
left a comment
There was a problem hiding this comment.
Requested changes have been made.
Hi Carol, You should fix the commit message as I mentioned and @renanrodrigo. Other than that it looks OK |
When a guest recipe console log was being processed during beaker upgrade, an exception was raised with call to startswith in labcontroller.utils.get_console_files. In the case of guest recipes, it is possible for the system name to be None. This change recognizes this case, reports this occurred, and discontinues getting console files for this guest recipes. Since exception is not raised, other recipes will continue to get their console files. Closes: BKR-5038
c4f3fb7 to
4f24136
Compare
I thought I had updated the message. Please check again. |
Cache is trolling me apparently. Sorry about that. |
When a guest recipe console log was being processed during beaker
upgrade, an exception was raised with call to startswith in
labcontroller.utils.get_console_files. In the case of guest recipes,
it is possible for the system name to be None. This change recognizes
this case, reports this occurred, and discontinues getting console
files for this guest recipes. Since exception is not raised, other recipes
will continue to get their console files.
Closes: BKR-5038