This repository was archived by the owner on Feb 4, 2018. It is now read-only.
Enable cors on deploy and apps#16
Open
SylvainCorlay wants to merge 1 commit intobinder-project:masterfrom
Open
Enable cors on deploy and apps#16SylvainCorlay wants to merge 1 commit intobinder-project:masterfrom
SylvainCorlay wants to merge 1 commit intobinder-project:masterfrom
Conversation
2c8a54e to
0d1573d
Compare
Author
|
Ping @rgbkrk |
rgbkrk
approved these changes
Jan 3, 2017
server/cors-settings.js
Outdated
| var path = require('path') | ||
| var fs = require('fs') | ||
|
|
||
| var contents = fs.readFileSync(path.join(process.env['HOME'], '.binder/cors.conf'), 'utf8') |
Member
There was a problem hiding this comment.
Since you're using path.join here, you might as well make this path.join(process.env['HOME'], '.binder', 'cors.conf')
Author
|
Thanks @rgbkrk I now use |
Member
|
Looks like the right approach. Since I don't have a hand in operations I can't judge whether this can/should be handled on binder (the deployed version). I certainly like the cors addition! |
Author
|
@freeman-lab do you think that we could get this one in? |
Author
|
Up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tackling binder-project/binder#93 and binder-project/binder#9
CORS settings for
deployandappscan be setup with acors.conffile in.binderright byweb.conf.