fix bug plotting-canvas not spanning the entire screen
#325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @TungVietLe is it possible for you to only do the PR for the fix, without the whitespace changes? Or at least separate that out? |
Contributor
|
Also I don't think we want to add jquery.js to the source like that. Can you exclude that change as well? |
Author
|
sure thing, I will try to change it right now! |
Author
|
i will make it a new pull request |
Contributor
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
plotting-canvasdoes not cover the entire screen. I my case, when I usenpm run serveit will spans, but if I usenpx lite-server, which is a local server, it somehow doesn't work. This is a fix on theCSSofsetup()to guarantee it will span whole screen on every server