Conversation
|
Is there a reason not to upgrade to the latest SP (incl. the Makefile), which would include this change? |
|
@rkratky Let me work on the full update. |
aspell from Makefile
@rkratky |
|
Haven't verified it thoroughly, but it builds and looks ok to me. |
There was a problem hiding this comment.
@geoffreynyaga The description for this PR just says we're updating our starter pack to a new version. Are the code changes in here copying from an existing project somewhere else? I'm not sure which parts of this are all new code needing a thorough review and which (if any) are copied from some already-reviewed source. Is there a link to the starter pack I should consult for this?
Description
We migrated the spellcheck functionality from
aspelltovalein this PR #4188.However, there was leftover commands in the docs Makefile that needed to be removed. They are never called and should have been deleted during the migration
Testing
Manual testing steps:
make spellcheckandmake spellingstill worksChecklist