Conversation
xavipg003
marked this pull request as ready for review
September 23, 2026 15:54
xavipg003
requested review from
carlcsaposs-canonical,
dragomirp,
juju-charm-bot,
marceloneppel,
oleksii-buhaiov and
taurus-forever
and removed request for
a team
September 23, 2026 15:54
marceloneppel
requested changes
Sep 23, 2026
marceloneppel
left a comment
Member
There was a problem hiding this comment.
Great work, @xavipg003.
marceloneppel
approved these changes
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL operator didn't follow CC008 spec for Terraform Juju provider support (I/O variable names, alphabetical order, etc.) and no tests were present. Therefore, support was added and both integration and native unit tests were added.
Remark: these tests will only be executed when any file inside these paths is modified:
paths:- "terraform/**"- "tests/terraform/**"- "tests/integration/terraform/**"- "tests/spread/test_terraform_deploy.py/**"- "tox.ini"- ".github/workflows/terraform.yaml"