patch: consume single-kernel lib 16.3.9 - #1997
Draft
marceloneppel wants to merge 3 commits into
Draft
marceloneppel wants to merge 3 commits into
marceloneppel wants to merge 3 commits into
Conversation
… URL Consume the lib from the current 16/edge HEAD (80bce27e683c262d14bc978838d95a72bc2ba7d2, [DPE-11195] feat(backups): pgBackRest service lifecycle and stanza check (8/19)) instead of the released 16.3.8 PyPI pin, to validate whether the latest library state wires up with the charm. The tip carries unreleased CharmState API (required s3_requirer, added in 3/19 #240 and reworked in 4/19 #241), so unit failures on the charm.py callsite are expected until the charm is adapted; draft-only CI probe.
Satisfy the single-kernel lib 16/edge tip API: CharmState now requires s3_requirer (added in 3/19 #240, reworked in 4/19 #241). Construct one lib-vendored S3Requirer(self, s3-parameters) and pass it to both CharmState and PostgreSQLBackups, which no longer constructs its own - ops permits only one S3Requirer object per charm (handle key is class name plus relation name, so a second instance raises RuntimeError). Unit test patch targets for get_s3_connection_info follow the lib-vendored module path. Backups/restore logic itself stays charm-owned until the backups-adopt-lib migration lands.
Replaces the temporary SHA archive URL pin with the released 16.3.9 version from PyPI (lib PR #324, publish run https://github.com/canonical/postgresql-single-kernel-library/actions/runs/36034388696). Identical code content to 16/edge head 80bce27e683c262d14bc978838d95a72bc2ba7d2 that was validated by this PR: full unit suite (210 passed), ty check, CI lint/unit/build.
1 task
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The single-kernel library published 16.3.9 (cut from 16/edge head 80bce27e683c262d14bc978838d95a72bc2ba7d2, lib PR canonical/postgresql-single-kernel-library#324) with a breaking
CharmStateAPI:s3_requirer: S3Requireris now a required constructor argument.Solution
postgresql-charms-single-kernel16.3.9 from PyPI with extras["postgresql", "vm"]; poetry.lock refreshed,poetry check --lockgreen.charm.pyconstructs one lib-vendoredS3Requirer(self, "s3-parameters")and passes it toCharmState.PostgreSQLBackupsreceives that instance (s3_requirer=kwarg) instead of constructing its own.src/backups.pyimports its s3 interface classes from the lib-vendored module; unit-test patch targets forget_s3_connection_infoupdated to match.Checklist