overlord/devicestate/handlers_reprovision.go: do not remove keyring keys - #17695
Draft
valentindavid wants to merge 5 commits into
Draft
valentindavid wants to merge 5 commits into
valentindavid wants to merge 5 commits into
Conversation
|
Thu Sep 24 14:12:30 UTC 2026 Test Predictor AnalysisPreparing
Executing
Restoring
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list of the below tests you wish to run (unskip plus test list must be valid yaml)
|
valentindavid
force-pushed
the
valentindavid/do-not-remove-keyring-keys
branch
from
September 23, 2026 10:52
4efa052 to
8670909
Compare
…ary keys Because the plainkey's primary key is not verified by secboot (it comes from verified disk), then we can sometimes get in a situation where 2 primary keys were used. In that case only reprovision can fix it.
To support auto repair on uc24, we need to ignore some invalid key data. But if all keys error with invalid key data, this should always need reprovision. Because at least one of them should have worked or given another error.
valentindavid
force-pushed
the
valentindavid/do-not-remove-keyring-keys
branch
from
September 24, 2026 11:40
8670909 to
fe749a4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.