Skip to content

i/builtin: [dcdbas-control] smi_data must be locked for use - #17697

Open
Mohit-Chachada wants to merge 1 commit into
canonical:masterfrom
Mohit-Chachada:fix-dcdbas-control-lock-permission
Open

Mohit-Chachada wants to merge 1 commit into
canonical:masterfrom
Mohit-Chachada:fix-dcdbas-control-lock-permission

Conversation

@Mohit-Chachada

Copy link
Copy Markdown
Contributor

https://www.kernel.org/doc/Documentation/dcdbas.txt describes that smi_data must be locked for use.

Systems management software must perform the following steps to execute
a SMI using this driver:

1) Lock smi_data.
2) Write system management command to smi_data.
3) Write "1" to smi_request to generate a calling interface SMI or
   "2" to generate a raw SMI.
4) Read system management command response from smi_data.
5) Unlock smi_data.

@Mohit-Chachada Mohit-Chachada added the Needs security review Can only be merged once security gave a :+1: label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.39%. Comparing base (1f194f6) to head (184d667).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17697      +/-   ##
==========================================
- Coverage   82.12%   78.39%   -3.74%     
==========================================
  Files        1417     1415       -2     
  Lines      200631   200579      -52     
  Branches     2503     2503              
==========================================
- Hits       164774   157234    -7540     
- Misses      33918    33927       +9     
- Partials     1939     9418    +7479     
Flag Coverage Δ
unittests 78.39% <ø> (-3.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Thu Sep 24 16:42:16 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/35767848852

Test Predictor Analysis

Executing

Test Success %
garden:arch-linux-64:tests/main/snapd-snap:lxd unavailable
garden:debian-12-64:tests/main/snapd-snap:lxd unavailable
garden:debian-sid-64:tests/main/snapd-snap:lxd unavailable
garden:fedora-44-64:tests/main/snapd-snap:lxd unavailable
garden:opensuse-tumbleweed-64:tests/main/snapd-snap:lxd unavailable
garden:opensuse-tumbleweed-selinux-64:tests/main/snapd-snap:lxd unavailable
garden:ubuntu-20.04-64:tests/main/snapd-snap:lxd unavailable
garden:ubuntu-22.04-64:tests/main/snapd-snap:lxd unavailable
garden:ubuntu-24.04-64:tests/main/snapd-snap:lxd unavailable
garden:ubuntu-26.04-64:tests/main/snapd-snap:lxd unavailable
openstack:debian-sid-64:tests/main/snapd-reexec:snapd 🔴 0.8%
openstack:ubuntu-26.10-64:tests/main/snapd-reexec:snapd 🔴 0.8%

Restoring

Test Success %
openstack:debian-sid-64:tests/main/snapd-reexec:snapd 🔴 0.8%
openstack:ubuntu-26.10-64:tests/main/snapd-reexec:snapd 🔴 0.4%

Skipped tests from snapd-testing-skip

If you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list of the below tests you wish to run (unskip plus test list must be valid yaml)

  • garden:fedora-44-64:tests/main/network-retry
  • garden:ubuntu-24.04-64:tests/main/apparmor-prompting-support
  • garden:ubuntu-24.04-64:tests/main/auto-refresh-retry
  • garden:ubuntu-24.04-64:tests/main/network-retry
  • garden:ubuntu-26.04-64:tests/main/apparmor-prompting-support
  • garden:ubuntu-26.04-64:tests/main/auto-refresh-retry
  • garden:ubuntu-26.04-64:tests/main/network-retry
  • openstack-arm:ubuntu-24.04-arm-64:tests/main/i18n
  • openstack-arm:ubuntu-24.04-arm-64:tests/main/interfaces-location-control
  • openstack-arm:ubuntu-core-24-arm-64:tests/main/i18n
  • openstack:amazon-linux-2023-64:tests/main/interfaces-location-control
  • openstack:arch-linux-64:tests/main/interfaces-location-control
  • openstack:centos-9-64:tests/main/interfaces-location-control
  • openstack:debian-12-64:tests/main/interfaces-location-control
  • openstack:debian-sid-64:tests/main/interfaces-location-control
  • openstack:debian-sid-64:tests/main/interfaces-network-status-classic
  • openstack:debian-sid-64:tests/main/interfaces-xdg-portal-permission-store
  • openstack:fedora-44-64:tests/main/interfaces-location-control
  • openstack:fedora-44-64:tests/main/network-retry
  • openstack:opensuse-16.0-64:tests/main/interfaces-location-control
  • openstack:opensuse-tumbleweed-64:tests/main/interfaces-location-control
  • openstack:opensuse-tumbleweed-selinux-64:tests/main/interfaces-location-control
  • openstack:ubuntu-16.04-64:tests/main/interfaces-location-control
  • openstack:ubuntu-18.04-64:tests/main/interfaces-location-control
  • openstack:ubuntu-20.04-64:tests/main/interfaces-location-control
  • openstack:ubuntu-22.04-64:tests/main/interfaces-location-control
  • openstack:ubuntu-24.04-64:tests/main/apparmor-prompting-flag-restart
  • openstack:ubuntu-24.04-64:tests/main/apparmor-prompting-integration-tests
  • openstack:ubuntu-24.04-64:tests/main/apparmor-prompting-prompt-restoration
  • openstack:ubuntu-24.04-64:tests/main/apparmor-prompting-smoke
  • openstack:ubuntu-24.04-64:tests/main/apparmor-prompting-snapd-startup
  • openstack:ubuntu-24.04-64:tests/main/apparmor-prompting-support
  • openstack:ubuntu-24.04-64:tests/main/auto-refresh-retry
  • openstack:ubuntu-24.04-64:tests/main/i18n
  • openstack:ubuntu-24.04-64:tests/main/interfaces-location-control
  • openstack:ubuntu-24.04-64:tests/main/interfaces-requests-activates-handlers
  • openstack:ubuntu-24.04-64:tests/main/network-retry
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-flag-restart
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-integration-tests
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-prompt-restoration
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-smoke
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-snapd-startup
  • openstack:ubuntu-26.04-64:tests/main/apparmor-prompting-support
  • openstack:ubuntu-26.04-64:tests/main/auto-refresh-retry
  • openstack:ubuntu-26.04-64:tests/main/i18n
  • openstack:ubuntu-26.04-64:tests/main/interfaces-location-control
  • openstack:ubuntu-26.04-64:tests/main/interfaces-requests-activates-handlers
  • openstack:ubuntu-26.04-64:tests/main/network-retry
  • openstack:ubuntu-26.10-64:tests/main/apparmor-prompting-flag-restart
  • openstack:ubuntu-26.10-64:tests/main/apparmor-prompting-integration-tests
  • openstack:ubuntu-26.10-64:tests/main/apparmor-prompting-prompt-restoration
  • openstack:ubuntu-26.10-64:tests/main/apparmor-prompting-smoke
  • openstack:ubuntu-26.10-64:tests/main/apparmor-prompting-snapd-startup
  • openstack:ubuntu-26.10-64:tests/main/apparmor-prompting-support
  • openstack:ubuntu-26.10-64:tests/main/interfaces-location-control
  • openstack:ubuntu-26.10-64:tests/main/interfaces-requests-activates-handlers

@bboozzoo bboozzoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mohit-Chachada Mohit-Chachada added this to the 2.79 milestone Sep 24, 2026
@github-actions github-actions Bot added the Auto rerun spread Auto reruns spread up to 4 times in non-draft PRs w/ >=1 approval and <20 fails in any fund. system label Sep 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto rerun spread Auto reruns spread up to 4 times in non-draft PRs w/ >=1 approval and <20 fails in any fund. system Needs security review Can only be merged once security gave a :+1:

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants