Conversation
Signed-off-by: Harry Pidcock <harry.pidcock@canonical.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 82.18% 78.38% -3.81%
==========================================
Files 1407 1419 +12
Lines 200453 200791 +338
Branches 2503 2503
==========================================
- Hits 164751 157393 -7358
- Misses 33759 33967 +208
- Partials 1943 9431 +7488
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Fri Sep 25 00:05:25 UTC 2026 Test Predictor AnalysisExecuting
Restoring
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list of the below tests you wish to run (unskip plus test list must be valid yaml)
|
ndyer
requested review from
natibek and
olivercalder
and
a balanced review from Copilot
September 23, 2026 09:00
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix correctly updates state modification tracking and includes regression coverage for both affected collections.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures pruned warnings and notices are persisted during state checkpointing.
Changes:
- Mark state modified when expired warnings or notices are removed.
- Add regression tests verifying checkpoint persistence.
| File | Description |
|---|---|
overlord/state/state.go |
Marks pruning mutations for checkpointing. |
overlord/state/warning_test.go |
Tests persisted warning pruning. |
overlord/state/notices_test.go |
Tests persisted notice pruning. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports a notices (and warnings) pruning persistence fix from pebble.
canonical/pebble#1083