i/builtin: lxd interface allows access to the connected lxd parallel instance - #17708
Mohit-Chachada wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered by tests, with no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the LXD interface’s AppArmor policy to support parallel-installed LXD instances.
Changes:
- Generates socket paths from the connected slot’s instance name.
- Adds regression coverage for standard and parallel LXD instances.
| File | Description |
|---|---|
interfaces/builtin/lxd.go |
Generates instance-specific AppArmor socket rules. |
interfaces/builtin/lxd_test.go |
Tests standard and parallel-instance socket access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thu Sep 24 15:56:36 UTC 2026 No spread result artifacts foundNo spread results JSON artifacts were available for this workflow run, so spread failures (if any) could not be reported. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17708 +/- ##
=======================================
Coverage 78.38% 78.38%
=======================================
Files 1422 1418 -4
Lines 200797 200787 -10
Branches 2503 2503
=======================================
- Hits 157388 157385 -3
+ Misses 33977 33961 -16
- Partials 9432 9441 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lxd-supportinterface is still marked as unsupported for parallel instances and the lxd team reported that parallel instances have never properly worked for lxd. But, i think we can still fix this part with thelxdinterface to have one less thing to fix if we ever want lxd to support this in the future.