Install a default SKIPDATA callback for SystemZ (#1495) #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please use tab for indentation. This PR assumes that this is unknown code, but what if it is data, which is the original motivation of this feature? |
Contributor
Author
|
If it's data, and not just an unknown instruction, then we'll skip a variable amount per query. Which, might look a little odd but will not lose data. Motivating examples now added to #1495 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the length of an unknown instruction fromt the top two bits.
This enables the disassembler to stay in sync with the intended
instruction stream.
Signed-off-by: Richard Henderson [email protected]