Downgrade sops dependency to v3.9.0#1727
Merged
joaopapereira merged 1 commit intocarvel-dev:developfrom May 12, 2025
Merged
Conversation
This intentionally downgrades mozilla/sops version to v3.9.0. The version v3.9.0 was built using MPL 2.0 licensed go module of hashicorp/vault, all the versions of sops greater than v3.9.0 are built using BSL 1.1 licensed go module of hashicorp/vault. Signed-off-by: Daman Arora <aroradaman@gmail.com>
90b5e72 to
983f945
Compare
joaopapereira
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This intentionally downgrades mozilla/sops version to v3.9.0. The version v3.9.0 was built using MPL 2.0 licensed go module of hashicorp/vault, all the versions of sops greater than v3.9.0 are built using BSL 1.1 licensed go module of hashicorp/vault.
sops v3.9.0 uses github.com/hashicorp/vault@v1.14.0 which is MPL 2.0 licensed, v3.9.1 uses uses github.com/hashicorp/vault@v1.15.0 which uses BUSL 1.1 (Business Source License 1.1).
Also, I noticed that the
dependencies.ymlfile is periodically update by thecarvel-bot#1663, we might need to figure out a way to check for license before upgrading the versions.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: