Skip to content

Conversation

@ZXShady
Copy link
Contributor

@ZXShady ZXShady commented Sep 11, 2025

I moved more stuff into the .cpp file and formatted the file and I removed recursion from the tuple printer for better compile times and readability.

@ZXShady ZXShady changed the title Move more of tostring.hpp into source file and add more stringifiers Move more of tostring.hpp into source file and remove tuple printing recursion Sep 12, 2025
@ZXShady ZXShady force-pushed the more_stringifying branch 2 times, most recently from 8d4633c to 4de4836 Compare September 12, 2025 14:32
@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.05%. Comparing base (8e4ab5d) to head (2718aec).
⚠️ Report is 5 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3028      +/-   ##
==========================================
- Coverage   91.08%   91.05%   -0.03%     
==========================================
  Files         202      202              
  Lines        8715     8716       +1     
==========================================
- Hits         7938     7936       -2     
- Misses        777      780       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@horenmar
Copy link
Member

Let's not reformat everything.

As I understand it, there are three separate changes

  1. catch_strnlen goes into .cpp
  2. Part of time-point stringifier goes into .cpp
  3. Tuple does not recurse to print iself.

Can you provide the PR with just these changes? Alternatively I can pick the changes later.

@ZXShady
Copy link
Contributor Author

ZXShady commented Oct 4, 2025

Hi sorry, I was away from my computer for this week.

@horenmar horenmar merged commit 33e6fd2 into catchorg:devel Oct 4, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants