chore: remove bundled chai#1694
Merged
Merged
Conversation
keithamus
reviewed
Aug 18, 2025
Member
keithamus
left a comment
There was a problem hiding this comment.
I'd prefer to split this into a few PRs and releases just to mitigate potential friction. We can release patch versions, and if we get issues a subsequent revert patch release is much easier.
Removes the chai bundle such that `chai.js` is now an entry point just like `index.js`. We're keeping it around for now since there may be users directly importing the file. It was already re-exporting what exists in `index.js`, so this shouldn't be a breaking change.
Contributor
Author
|
i've opened #1695 and changed this to only remove the bundle |
keithamus
approved these changes
Aug 18, 2025
Member
keithamus
left a comment
There was a problem hiding this comment.
I'd prefer to split this into a few PRs and releases just to mitigate potential friction. We can release patch versions, and if we get issues a subsequent revert patch release is much easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the chai bundle such that
chai.jsis now an entry point justlike
index.js.We're keeping it around for now since there may be users directly
importing the file. It was already re-exporting what exists in
index.js, so this shouldn't be a breaking change.Also sets the
filesarray so we now publish only the necessary files.