Simplify Nox session for code coverage #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4a139d to
6636419
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the handling of
posargsin the Nox session for Coverage.py.Pass empty
posargswhen scheduling the coverage sesseion viasession.notify. This avoids invokingcoveragewith options intended for pytest. Previously, our solution relied on inspecting a private attribute ofnox.Session.The
posargsparameter forsession.notifywas introduced in Nox 2021.6.6.Use the
nox.needs_versionattribute to declare the dependency on Nox >= 2021.6.6.Note: This requires nox-poetry 0.8.6 to avoid an error from mypy.