Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Comments

Topic/dockerfile update#2

Merged
sameo merged 2 commits intoclearcontainers:masterfrom
chavafg:topic/dockerfile_update
Mar 7, 2017
Merged

Topic/dockerfile update#2
sameo merged 2 commits intoclearcontainers:masterfrom
chavafg:topic/dockerfile_update

Conversation

@chavafg
Copy link
Contributor

@chavafg chavafg commented Feb 15, 2017

This PR contains 2 commits that :

  • Remove old Dockerfiles that no longer worked because of changes in cc-oci-runtime
  • Add new Dockerfile for building cc-oci-runtime in Ubuntu.

@@ -0,0 +1,71 @@
# This file is part of cc-oci-runtime.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this path please be 2.1/build/ubuntu/Dockerfile ? the cc prefix and suffix is redundant, we know we're building Clear Containers :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure


# Create directory for clonning cc-oci-runtime
RUN mkdir -p /root/go/src/github.com/01org

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating the directory and git cloning the code, could you please try to do a:

go get -d github.com/01org/cc-oci-runtime

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried that, but got this:

package github.com/01org/cc-oci-runtime: no buildable Go source files in /root/go/src/github.com/01org/cc-oci-runtime
The command '/bin/sh -c go get github.com/01org/cc-oci-runtime' returned a non-zero code: 1

and the docker build command cannot continue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chavafg can you try go get -d
This should not build it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh! go get -d will still try to compile the package. What it doesn't do is go install :/

@@ -1,50 +0,0 @@
#
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please all the existing files and move them to 2.1/run/<distro> instead ?
I know they're broken, but if we remove them we will have a hard time fixing them...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

2.1/run directory was created to track files that belong
to 2.1 and its purpose is to run clear-containers

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
README.md Outdated
Those are Dockerfiles for building Ubuntu, Fedora and Clear Linux
containers capable of running the Clear Container container runtime
as the default OCI runtime.
This repoository contains different Dockerfiles for building Ubuntu,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/repoository/repository/

@chavafg chavafg force-pushed the topic/dockerfile_update branch from be50240 to 5880c44 Compare February 15, 2017 19:30
Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg chavafg force-pushed the topic/dockerfile_update branch from 5880c44 to 3673c18 Compare February 15, 2017 19:43
ENV HOME /root
WORKDIR $HOME

# Clone and clone cc-oci-runtime

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clone and clone? :)

@sameo sameo merged commit 669fb48 into clearcontainers:master Mar 7, 2017
@chavafg chavafg deleted the topic/dockerfile_update branch June 12, 2017 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants