Skip to content

Drop optional shap dependency#72

Merged
david-cortes-intel merged 2 commits into
conda-forge:mainfrom
david-cortes-intel:drop_shap
Dec 30, 2025
Merged

Drop optional shap dependency#72
david-cortes-intel merged 2 commits into
conda-forge:mainfrom
david-cortes-intel:drop_shap

Conversation

@david-cortes-intel
Copy link
Copy Markdown
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR drops the shap library from the list of test dependencies, which is an optional dependency used only for one test in model builders from lightgbm.

Motivation: this shap library doesn't have python3.14 support, and is the only dependency blocking a transition for scikit-learn-intelex:
conda-forge/shap-feedstock#101

It appears they might have repeated issues getting builds for new python versions when they release due to their numba dependency:
shap/shap#4236

Hence, better to drop it altogether and maybe add it back in the future if we see that it gets builds for python3.15 within a reasonable period after its release.

@david-cortes-intel
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20591628965. Examine the logs at this URL for more detail.

@david-cortes-intel
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20591795620. Examine the logs at this URL for more detail.

@david-cortes-intel
Copy link
Copy Markdown
Contributor Author

CI failures are about this test:

tests/test_memory_usage.py::test_memory_leaks[(2000, 50)-NuSVC

It is checking for memory leaks, but the test is not well designed and can fail in cases in which no leak occurs. I think it can be ignored.

@ethanglaser
Copy link
Copy Markdown
Contributor

CI fails come from issue resolved by uxlfoundation/scikit-learn-intelex#2868

@david-cortes-intel david-cortes-intel merged commit 6f60fe5 into conda-forge:main Dec 30, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants