fix: case when reranker returns invalid scores array

[uinstinct]

Description

The following error used to happen when the reranker model returned an invalid response.
Failed to rerank retrieval results TypeError: Cannot read properties of undefined (reading 'sort'). More about the RCA in the ticket.

• add a zod validation schema for voyage ai response
• check if scores array is valid in DocsContextProvider

resolves CON-2661

Checklist

• [] I've read the contributing guide
• [] The relevant docs, if any, have been updated or created
• [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

---

Summary by cubic

Fixed a crash when the reranker model returned an invalid scores array by adding response validation and handling invalid cases.

• Bug Fixes
  • Added Zod schema validation for the Voyage AI reranker response.
  • Checked for a valid scores array before sorting in DocsContextProvider.

[RomneyDa]

@uinstinct see nitpick comment. Just to double check, has this been tested with voyage reranker?

[RomneyDa]

You can use the zod output here, it will be typesafe!
I'd recommend safeParse so you can gracefully handle invalid values

[uinstinct]

actually I wanted the throw the error directly if parsing failed like we do here

continue/core/llm/llms/Voyage.ts

Lines 30 to 34 in b28d0f2

	if (resp.status !== 200) {
	throw new Error(
	`VoyageReranker API error ${resp.status}: ${await resp.text()}`,
	);
	}

[RomneyDa]

@uinstinct the schema.parse will throw an error if parsing fails. i.e. if the status is 200 then presumably the parse with throw an error because the response won't match the expected format, which means the status check will never be reached

[uinstinct]

yeah, got it.

[uinstinct]

Just to double check, has this been tested with voyage reranker?

Yes had verified on Voyage reranker

[RomneyDa]

@uinstinct sorry for the confusion,
I think the schema parser is a great idea, I just meant that the parsing error needs to be handled if it is parsed before the response status is checked

EDIT I was wrong about the order here, the main concern now is that the parse will throw an ugly zod error so should be gracefully handled

[sestinj]

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[sestinj]

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀