refactor: remove cosmos-db as a dep

[tac0turtle]

Summary by CodeRabbit

• New Features

  • Introduced GoLevelDB implementation for key-value store operations.
  • Added PrefixDB struct for namespacing KVStores.

• Bug Fixes

  • Enhanced error handling in the Format method of the HexBytes type.

• Refactor

  • Updated multiple files to use corestore instead of dbm for database operations.
  • Simplified database initialization and setup across various test files.
  • Replaced db.Batch with store.Batch in relevant functions and structs.

• Documentation

  • Updated explanations of IAVL trees, range proofs, and proof generation in Go code.

• Chores

  • Updated golangci_version in the Makefile to v1.59.1.
  • Adjusted dependencies in go.mod for improved compatibility and performance.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

The update primarily modernizes dependencies and refines database interactions within the project. Key changes include upgrading golangci-lint, transitioning from dbm to corestore for batch processing and iteration, and streamlining database initialization across tests. These alterations enhance code consistency, maintainability, and performance, reflecting a concerted effort to leverage updated libraries and improve overall project structure.

Changes

Files/Groups	Change Summary
Makefile	Update golangci_version from v1.55.2 to v1.59.1.
basic_test.go	Modify Iterate function call by removing the value parameter reference.
batch.go, batch_test.go	Update BatchWithFlusher to use corestore.Batch instead of dbm.Batch; remove backend parameter.
benchmarks/bench_test.go	Import corestore, update parameter types, database initialization, error handling, and logging.
benchmarks/cosmos-exim/main.go	Replace tmdb with idbm for database operations.
cmd/go.mod	Add specific version for cosmossdk.io/core, remove indirect tag.
cmd/iaviewer/main.go, wrapper.go	Modify MutableTree instantiation, introduce Wrapper struct.
db/README.md	Update import formatting and adjust indentation within the main function.
db/goleveldb.go	Introduce GoLevelDB implementation for key-value store operations.
db/memdb.go	Update package import and function signatures to use corestore types.
db/prefixdb.go	Provide PrefixDB struct to namespace multiple corestore.KVStores.
db/types.go	Update imports and function return types to use corestore types.
diff_test.go	Modify callback function signature in TraverseStateChanges method.
docs/proof/proof.md	Update explanation of IAVL trees, range proofs, and proof generation.
fast_iterator.go, iterator.go	Change import statement and type usage to corestore.
go.mod	Add github.com/syndtr/goleveldb, update golang.org/x/crypto, remove various indirect dependencies.
immutable_tree.go, mutable_tree.go	Update return type of Iterator method from dbm.Iterator to corestore.Iterator.
import.go, mock/db_mock.go	Change import path and update return types to use corestore types.
iterator_test.go	Replace references to dbm.Iterator with corestore.Iterator in tests.
migrate_test.go, tree_random_test.go, tree_test.go	Replace dbm.NewDB with dbm.NewGoLevelDB and simplify database initialization.
mockgen.sh	Update package import path to cosmossdk.io/core.
nodedb.go	Replace dbm types with corestore types for batch writing and iterators.
testutils_test.go	Change assertIterator function signature to use corestore.Iterator.
unsaved_fast_iterator.go	Replace dependency on dbm with corestore for the fastIterator field.

Poem

In the code where bytes do dance,
We’ve made a change, a bold advance.
From dbm to corestore we glide,
With golangci-lint by our side.
Trees and batches, now refined,
In this update, progress you'll find.
🌟 Happy coding, every line aligned! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cool-develope]

break indentation?

[cool-develope]

overall, lgtm! small concern of RocksDB users won't be compatible

[tac0turtle]

overall, lgtm! small concern of RocksDB users won't be compatible

what do you mean? since db is passed from above would it not work out of the box?

[cool-develope]

overall, lgtm! small concern of RocksDB users won't be compatible

what do you mean? since db is passed from above would it not work out of the box?

no, I'd like to add the small godoc or description of how to use wrapper for pebbledb or rocksdb users

[tac0turtle]

overall, lgtm! small concern of RocksDB users won't be compatible

what do you mean? since db is passed from above would it not work out of the box?

no, I'd like to add the small godoc or description of how to use wrapper for pebbledb or rocksdb users

in the cmd go.mod right?

[cool-develope]

@Mergifyio backport release/v1.2.x

[mergify]

backport release/v1.2.x

✅ Backports have been created

Details

• #968 refactor: remove cosmos-db as a dep (backport #955) has been created for branch release/v1.2.x but encountered conflicts