Add coverage_reporter_platform parameter#49
Merged
afinetooth merged 19 commits intomasterfrom Nov 2, 2024
Merged
Conversation
…iate architecture-specific binary of coverage-reporter. Add tests.
…t the version they passed was valid.
…ust test the last possible enum value, arm64.
…er to test unless we want to test fail_on_error.
…tempts, to deliver a helpful error message before a possible shell execution failure.
…tempts, to deliver a helpful error message before a possible shell execution failure.
…rm was empty / not set.
…orrect value to match architecure in our script, and catch a change if it ever happens.
…erstand why we are sometimes getting this error.
…r version test, as it's verbose and redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
coverage_reporter_platformparameter with logic to download and use the appropriate architecture-specific binary ofcoverage-reporter.To Do
coverage_reporter_platformparameter and logic to use architecture-specific binary ofcoverage-reporter.coverage_reporter_platform.