Rename mapping from parent to parentId#1313
Open
boudewijn-zicht wants to merge 1 commit intocraftcms:5.xfrom
Open
Rename mapping from parent to parentId#1313boudewijn-zicht wants to merge 1 commit intocraftcms:5.xfrom
boudewijn-zicht wants to merge 1 commit intocraftcms:5.xfrom
Conversation
The attribute `parentId` is used in Craft to signify the value of the parent element, if any. Therefore, the mapping handle should also be `parentId`. This patch changes the mapping handle from `parent` into `parentId`. This allows the comparison code to properly verify that an existing parent already exists. Without this patch the current comparison will use the `parent` property that does not exist in a Craft entry. This should have been `parentId` which does exist.
4a673af to
e74d28f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute
parentIdis used in Craft to signify the value of the parent element, if any. Therefore, the mapping handle should also beparentId.This patch changes the mapping handle from
parentintoparentId. This allows the comparison code to properly verify that an existing parent already exists. Without this patch the current comparison will use theparentproperty that does not exist in a Craft entry. This should have beenparentIdwhich does exist.A migration is included to rename
parenttoparentIdin any existing migrations that may already exist.