Added support for custom field matching on Commerce Products and Variants fields#1717
Open
jmauzyk wants to merge 1 commit intocraftcms:5.xfrom
Open
Added support for custom field matching on Commerce Products and Variants fields#1717jmauzyk wants to merge 1 commit intocraftcms:5.xfrom
jmauzyk wants to merge 1 commit intocraftcms:5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I created this pull request to address #902. To add a bit more context regarding our specific use case, we use a PIM to manage our product data, and import the product data into Craft using Feed Me. Currently, there is no way to match Commerce Products or Variants fields using custom fields as is possible for with other element fields like Entries. It's also not possible to match Commerce Products by default SKU.
As a result, the only way we're currently able to match Commerce elements is by ID, which requires ingesting that data from Craft back into our PIM. This PR would allow us to match products and variants using data that is already in our PIM instead, reducing additional work.
While I'm not deeply familiar with the inner workings of Feed Me, it seemed like the functionality to support this was already in place and it mostly needed field options to be populated for selection. I tested matching products using default SKU and a custom field in my local dev environment, and both worked without issue.
Thanks for your consideration!