Trigger event from object, not static method#737
Open
kristiansp wants to merge 1 commit intocraftcms:5.xfrom
Open
Trigger event from object, not static method#737kristiansp wants to merge 1 commit intocraftcms:5.xfrom
kristiansp wants to merge 1 commit intocraftcms:5.xfrom
Conversation
When using behaviors to handle events, event won't fire when it is called with the static method, as the behavior is added dynamically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using behaviors to handle events, event won't fire when it is called with the static method, as the behavior is added dynamically, but when using
this->trigger()it will, so I suggest to trigger it from the object itself. (If there's no specific reason to do it otherwise, perhaps all event triggers could be changed in the same way.)Fixes #730