Skip to content

Conversation

@bohendo
Copy link
Collaborator

@bohendo bohendo commented Oct 4, 2023

resolves #14

cds into the input directory before running the workload command so the user doesn't need to remember to do this manually.

Summary by CodeRabbit

  • New Feature: Added the ability to specify an input directory for running workload commands. The application will automatically change to this directory before executing the command, simplifying user workflow.
  • Refactor: Updated file paths for output files and logs to use absolute paths instead of shorthand, improving consistency and reducing potential errors.
  • New Feature: Enhanced script functionality to create the output directory under the user's home directory and handle the downloading and unzipping of the input archive into the specified input directory.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Image description CodeRabbit

Walkthrough

The changes introduced add support for specifying an input directory and automatically changing to that directory before running the workload command. This is achieved by updating the run command, modifying file paths, and adjusting the setup script. The working directory and file paths are now more flexible and user-friendly.

Changes

File(s) Summary
cmd/cloudexec/launch.go, cmd/cloudexec/user_data.go, cmd/cloudexec/user_data.sh.tmpl Added a new field InputDirectory to the UserData struct and updated the run command to execute from this directory. Paths for output files and logs have been updated to use the home variable (/root). The setup script now creates the output directory under the home directory, downloads and unzips the input archive into the specified input directory, and changes the working directory to the input directory before executing the workload command.

"In the land of code, where logic intertwines,
A rabbit hopped forth, leaving tracks in lines.
With each hop and skip, a change was made,
In directories deep, where data stayed.
Now run commands with ease, no need for manual steer,
Celebrate these changes, with a carrot 🥕 or cheer! 🎉"


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 49d7ed8 and 9c9a2c0 commits.
Files selected (3)
  • cmd/cloudexec/launch.go (1)
  • cmd/cloudexec/user_data.go (2)
  • cmd/cloudexec/user_data.sh.tmpl (4)
Files ignored due to filter (1)
  • example/cloudexec.toml
Files skipped from review due to trivial changes (2)
  • cmd/cloudexec/launch.go
  • cmd/cloudexec/user_data.go
Review comments generated (4)
  • Review: 2
  • LGTM: 2

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 9c9a2c0 and 8ae2aa6 commits.
Files selected (2)
  • cmd/cloudexec/launch.go (1)
  • cmd/cloudexec/user_data.sh.tmpl (4)
Review comments generated (5)
  • Review: 2
  • LGTM: 3

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 8ae2aa6 and 20bc467 commits.
Files selected (1)
  • cmd/cloudexec/user_data.sh.tmpl (4)
Review comments generated (4)
  • Review: 2
  • LGTM: 2

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@bohendo bohendo merged commit bb00055 into main Oct 5, 2023
@bohendo bohendo deleted the 14-auto-cd branch October 5, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auto-cd into the specified input directory

2 participants