Bitcoin multisig address safe time source #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingela
reviewed
Dec 25, 2018
| // Getting time | ||
| val time = details[ADDRESS_GENERATION_TIME_KEY]!!.toLong() | ||
| // Removing generation time. Only public keys remain | ||
| details.remove(ADDRESS_GENERATION_TIME_KEY) |
Member
There was a problem hiding this comment.
We can rewrite it without line 98 since remove: @return the previous value associated with the key, or `null` if the key was not present in the map.
Contributor
Author
There was a problem hiding this comment.
Sounds cool.
| } | ||
| logger.info { "Address $msAddress was added to wallet. Current wallet state:\n${walletFile.wallet}" } | ||
| } else if (notaryKeys.size != peers) { | ||
| logger.info { "Not enough keys are collected to generate a multisig address(${notaryKeys.size} out of ${peers})" } |
Contributor
Author
There was a problem hiding this comment.
Oh, yeah. You are right. It will be fixed.
| logger.info { "Address $msAddress was added to wallet. Current wallet state:\n${walletFile.wallet}" } | ||
| } else if (notaryKeys.size != peers) { | ||
| logger.info { "Not enough keys are collected to generate a multisig address(${notaryKeys.size} out of ${peers})" } | ||
| return@of |
Member
There was a problem hiding this comment.
Don't we need to throw something instead of just return@of ?
Contributor
Author
There was a problem hiding this comment.
No. It simply means that we are in the middle of the process.
| addressInfo.toJson(), | ||
| BigInteger.valueOf(generationTime) | ||
| ).fold({ | ||
| //TODO this save will probably corrupt the wallet file |
Member
There was a problem hiding this comment.
Is it bad? What should we do with that in the future?
Contributor
Author
There was a problem hiding this comment.
It's very bad. But it also outdated)
grimadas
approved these changes
Dec 25, 2018
| addressInfo.toJson(), | ||
| BigInteger.valueOf(generationTime) | ||
| ).fold({ | ||
| //TODO this save will probably corrupt the wallet file |
Contributor
There was a problem hiding this comment.
Can you make a task for that?
Mingela
approved these changes
Dec 25, 2018
Alexey-N-Chernyshov
added a commit
that referenced
this pull request
Feb 6, 2019
Release v0.2.1-alpha * Bitcoin deploy notes (#319) * Boot repackage was disabled (#315) * add more logs to eth registration * add more logs to eth registration * Bitcoin rollback (#321) * Bitcoin rollback in case of network failures (#323) * Bitcoin multisig address safe time source (#325) * Ignoring failed Iroha account creation command (#324) * Kill deposit if Iroha is not functioning (#326) * add automatic relay deployment logic * Separate shadow jar (#327) * optimized import * fix config helper * add Sora iroha account to genesis and tests for Sora integration * fix dogecoin precision (actual 9) * rename getAccountAsset -> getAccountAssetBalance * change getAccountAssets -> getIrohaAccountBalance * Bitcoin dynamic fee rate (#329) * Feature/healthcheck (#333) * Add readme * Add healthcheck endpoints * Fix test compiler error * Port increment * Remove registration endpoint * Transition to IPJ, Iroha rc2 version update (#335) * Feature/iroha pure java (#307) * move crypto to Iroha Pure Java library * Transition to IPJ, Iroha rc2 version update (#330) * Transition to IPJ * Iroha rc1 update * Test fixes * Iroha rc2 update * Updated permissions, roles, testing account * Test fixes * Update batches * Fixed status streaming and batch testing * Switched to ordered batches and to Query API of IPJ * More queries refactoring, changed wrapper * Unit tests fixes * Ignored one more unit test * Integration tests fixes * fixup! Integration tests fixes * fixup! Integration tests fixes * fixup! fixup! Integration tests fixes * Config test repaired * Environment variables configs (#336) * Added prioritized environment variables config loading * Fixed working directory of eth services (#338) * Fixed notary pub key (#340) * Fixed notary pub key * Deleted unused notary keys * fix 'mkdir -p' in Jenkins build-logs (#341) * Bitcoin services stabilization after migration to IPJ (#342) * Automatic BTC addresses generation (#337) * Bitcoin-cli in gradle (#344) * Feature/tester permissions (#343) * add permissions for tester account * fix duplication of can_read_assets * Fixed PeerGroup.stop() * Fixing IPJ listener bug (#346) * Relevant docker files (#345) * Updated docker files, added bitcoin services * Deleted variables * Fixed jenkinsfile variables names * Fixed main classes * Fix wait for iroha bug (#348) * Fix wait for iroha bug * Add network to dev * Fix typo * Fix btc docker. Move dw and address geneartion from single to full (#349) * Email notifications * Added build commands to Jenkinsfile (#351) * Feature/registration (#334) * Fixed message * Fixing build (#352) * Fixed peer group close() (#354) * SMTP dumbster integration test (#355) Signed-off-by: Alexey Chernyshov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Bug
We use Iroha multisig transactions to create Bitcoin addresses. A previous source of time was a node time, meaning that multisig will never be succeeded because it will have different hash value on different nodes. Now we set time at caller level before address generation process starts. Those who starts address generation process also sets a time for a current address generation session. This time will be used by multiple nodes.